-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error messages when instantiating an SRAFileReader #460
Comments
@a-nikitiuk @kwrodarmer Can you take this one please. |
Yes, we have already been working on a new reporting framework for this, as you have suggested, based upon various exception types. |
5 tasks
Can this be closed (fixed in #638 ?) |
Yes, it should be |
Closed via #638. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently constructing a new
SRAFileReader
callsSRAAccession.isValid()
and throws an exception sayingInvalid SRA accession was passed to SRA reader
ifisValid
returns false.Since is valid can fail for a number of reasons, this is not a very helpful message. It's particularly not helpful because it could actually be a valid accession, but SRA is just not supported.
This should be improved so that someone instantiating an SRAReader can tell WHY it was considered invalid.
The text was updated successfully, but these errors were encountered: