Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages when instantiating an SRAFileReader #460

Closed
lbergelson opened this issue Feb 4, 2016 · 5 comments
Closed

Improve error messages when instantiating an SRAFileReader #460

lbergelson opened this issue Feb 4, 2016 · 5 comments

Comments

@lbergelson
Copy link
Member

Currently constructing a new SRAFileReader calls SRAAccession.isValid() and throws an exception saying Invalid SRA accession was passed to SRA reader if isValid returns false.

Since is valid can fail for a number of reasons, this is not a very helpful message. It's particularly not helpful because it could actually be a valid accession, but SRA is just not supported.

This should be improved so that someone instantiating an SRAReader can tell WHY it was considered invalid.

@lbergelson
Copy link
Member Author

@a-nikitiuk @kwrodarmer Can you take this one please.

@kwrodarmer
Copy link

Yes, we have already been working on a new reporting framework for this, as you have suggested, based upon various exception types.

@cmnbroad
Copy link
Collaborator

Can this be closed (fixed in #638 ?)

@a-nikitiuk
Copy link
Contributor

Yes, it should be

@cmnbroad
Copy link
Collaborator

Closed via #638.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants