Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in SAMRecordSetBuilder #419

Closed
magicDGS opened this issue Jan 2, 2016 · 1 comment
Closed

Bug in SAMRecordSetBuilder #419

magicDGS opened this issue Jan 2, 2016 · 1 comment
Assignees
@tfenne

Comments

@magicDGS
Copy link
Member

magicDGS commented Jan 2, 2016

In the PR #408 I changed SamLocusIteratorTest to use SAMRecordSetBuilder as requested, but SamLocusIteratorTest.testEmitUncoveredLoci() fails (even with the previous implementation of SamLocusIterator) but without using the builder it is still working.

It seems that the problem comes from the SAMRecordSetBuilder implementation, when adding fragments with a header that differs from the default (it use the private static chromosomes' array).
This was referenced Jan 2, 2016
Closed
Closed
@magicDGS
Copy link
Member Author

magicDGS commented Jan 2, 2016

PR #421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tfenne tfenne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tfenne @magicDGS