Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAM: 8-Bin Base Quality Compression #1658

Open
JWollnik opened this issue Mar 8, 2023 · 1 comment
Open

CRAM: 8-Bin Base Quality Compression #1658

JWollnik opened this issue Mar 8, 2023 · 1 comment
Labels

Comments

@JWollnik
Copy link

JWollnik commented Mar 8, 2023

Description of the issue:

Is it possible to use the 8-Bin Base Quality Compression with the new overhauled CRAM support in 3.0.5?

#442 indicates that this would be possible with CRAMEncodingStrategy. However, it's not really clear from the API or release notes how to achieve this. In the past (e.g. 2.18.1) it has been possible to use new QualityScorePreservation("*8") to achieve such a compression.

Your environment:

  • htsjdk version 3.0.5
  • java 17
  • RHEL linux
@JWollnik JWollnik changed the title 8-Bin Base Quality Compression CRAM: 8-Bin Base Quality Compression Mar 8, 2023
@cmnbroad
Copy link
Collaborator

cmnbroad commented Mar 13, 2023

@JWollnik This isn't supported by htsjdk CRAM. The CRAMEncodingStrategy class is intended to be used to support such encoding parameters, but it currently doesn't support score binning, and is not exposed or documented (at least not as part of the SMFileWriter API). Its only used internally for creating test case variations in tests.

As for the old QualityScorePreservation class, the original htsjdk CRAM implementation accepted it as a parameter, but it was neither documented nor implemented. It really should never have been allowed into htsjdk in that state, so it was removed.

@cmnbroad cmnbroad added the cram label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants