Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow logging to be disabled #420

Closed
aeshirey opened this issue Jun 25, 2021 · 4 comments
Closed

Allow logging to be disabled #420

aeshirey opened this issue Jun 25, 2021 · 4 comments

Comments

@aeshirey
Copy link

I run WinCompose from my OneDrive, synced across three machines. It seems that a recent update has changed logging, as I am constantly getting toast notifications from OneDrive that changes to wincompose-MY-MACHINE.log couldn't be merged, so another copy was created. This happens repeatedly and from multiple machines, so it slowly starts to accumulate log files and pop up these notifications.

Looking at these log files, I don't see anything particularly relevant to most day-to-day uses -- I'm only seeing indications of what window got focus. Can logging be disabled to prevent these .log files from being created/updated (or at least to disable the focus logs)? Or should the "Window...got focus" messages be reverted to Debug level?

@samhocevar
Copy link
Owner

The “window got focus” messages are indeed an error, and they will no longer be here in the next release. Sorry about that.

The log files are stored in %LOCALAPPDATA%\WinCompose which should be specific to the machine (in contrast to the configuration files that are stored in %APPDATA%\WinCompose, which is shared between machines). I am unsure why the log file is called wincompose-MY-MACHINE.log in your case; do you run the installer version of WinCompose or the portable version?

@aeshirey
Copy link
Author

I use the portable version, extracted directly into a OneDrive folder. Since the exe is running on multiple machines, I get enumerated log files for each machine name (eg, wincompose-DESKTOP-ABCD.log, wincompose-DESKTOP-ABCD-2.log, ..., wincompose-HOMELAPTOP.log, ...)

@samhocevar
Copy link
Owner

Hi! I have demoted the focus messages (and a few others) to Debug level in WinCompose 0.9.11. Do you think this is good enough to close the issue?

@aeshirey
Copy link
Author

aeshirey commented Sep 8, 2021

So far, it appears that logging is now (appropriately) reduced from where it was at. If the problem recurs, I'll reopen. Thanks!

@aeshirey aeshirey closed this as completed Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants