Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty tags are serialised incorrectly, causes UI issue in Buku #139

Open
samhh opened this issue Feb 16, 2020 · 1 comment
Open

Empty tags are serialised incorrectly, causes UI issue in Buku #139

samhh opened this issue Feb 16, 2020 · 1 comment
Labels

Comments

@samhh
Copy link
Owner

samhh commented Feb 16, 2020

Here's how we're currently serialising our array of tags back to the format that Buku/SQLite want:

delimiter + bookmark.tags.join(delimiter) + delimiter

This is correct when bookmark.tags is non-empty (e.g. ,apple,, ,apple,banana,, etc), but incorrect when it's empty. What we want is ,, and what we actually produce is ,,.

Whilst this doesn't outright crash Buku or anything, it does result in the bookmarks displaying incorrectly - displaying empty tags where it would otherwise hide them i.e.:

What we should see in Buku:

1. title [123]
   > url

What we actually see:

1. title [123]
   > url
   #
@samhh samhh added the bug label Feb 16, 2020
@samhh
Copy link
Owner Author

samhh commented Feb 27, 2020

Trivially fixed in purescript branch, but not yet addressed in TypeScript/master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant