Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking changes to Last() in 1.42.0 #493

Closed
nicwaller opened this issue Jul 15, 2024 · 1 comment
Closed

breaking changes to Last() in 1.42.0 #493

nicwaller opened this issue Jul 15, 2024 · 1 comment

Comments

@nicwaller
Copy link

I noticed that version v1.42.0 has some breaking changes that are not mentioned in the release notes. Specifically, #474 (5aa64ef) changes the return type of Last():

  • before (T, error)
  • after (T, bool)

This is a breaking change that requires downstream consumers of samber/lo to make changes. As you're probably aware, backward-compatibility is highly valued in Go modules.

Please consider updating the release notes for v1.42.0 to mention this breaking change. 🙏
@samber
Copy link
Owner

samber commented Jul 15, 2024

You're right. I made a change.

@samber samber closed this as completed Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicwaller @samber