Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add archives, add jekyll-menus support, fix RSS #31

Closed
wants to merge 14 commits into from
Closed

Add archives, add jekyll-menus support, fix RSS #31

wants to merge 14 commits into from

Conversation

benniemosher
Copy link
Contributor

@benniemosher benniemosher commented Jan 14, 2020

Adds custom logo location to use Gravatar or other hosting.

Closes: #8

@benniemosher
Copy link
Contributor Author

@thelehhman This PR catches up and rebases my changes that you had requested in #28

@samarsault
Copy link
Owner

Thanks @benniemosher.
There's a problem with this PR though , i.e. we can't use jekyll-menus because github pages doesn't support it. Github pages compatibility is highly desired.

@benniemosher
Copy link
Contributor Author

@thelehhman suggested course here? I need jekyll-menus to support forestry.io, but would prefer to not verge from your repository here. Suggestions?

@samarsault
Copy link
Owner

What purpose does jekyll-menus serve?

@benniemosher
Copy link
Contributor Author

It allows you to build menus based off of a data file, or off of front matter in the post/page. Forestry.io has a really nice UI built in that requires jekyll-menus to work, that is why I am trying to migrate there.

@samarsault
Copy link
Owner

Move the archives and RSS to a separate PR.
I don't think we need this menus feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About tags
2 participants