-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Suppress a configurable domain in the generated minion_id #49212
Comments
thanks for the PR!! As the pr resolves this issue I will close but please let me know if it needs to be reopened :) |
thank you, @Ch3LL |
Hi @Ch3LL, I think the requested changes are from terminalmage, I asked him. |
glad you got it figured out. let me know if can help with anything else :) |
Yep, and terminalmarge already explained his request in all details. Thank you for the offer. I just looked at your PR #48866. First I need to verify the installer. |
Proposal
When the salt minion lacks an id, utils.network.generate_minion_id() generates a fully qualified domain name, using a variety of sources.
I propose a new setting
minion_id_generate_no_domain
, to suppresses a single domain in the result of above function.Current Behavior
The function returns
king_bob.foo.bar
Proposed behavior:
Without
minion_id_generate_no_domain
, as currently.With
minion_id_generate_no_domain = foo.baz
, as currentlyWith
minion_id_generate_no_domain = foo.bar
, the function returnsking_bob
The text was updated successfully, but these errors were encountered: