openbsdrcctl_service: ignore retcode to prevent spurious errors #62131
Conversation
Non-zero retcode is expected (to signal "service not running", for example); this should not be logged as an error.
|
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
|
Hi @raymonad, this will need tests and a changelog before we can get this merged in. |
|
OK. I am planning to set up an actual Salt development environment and investigate/report/experiment with some other problems/enhancements, but I don't expect to get around to that very soon. So I was hoping this small change could do without serious tests, even if requirements are stricter now than when that other PR was merged in 2016, but then it'll have to wait a bit (for me or another interested party). |
MKLeb
added
Needs-Testcase
|
@raymonad Any updates here? |
|
Congratulations on your first PR being merged! 🎉 |
Follow-up to #33294 which only updated the older of the two openbsd service modules.