Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't set HTTP headers as arg to s3.put to ensure correct Content-Type is set #49649

Closed
colin-stubbs opened this issue Sep 13, 2018 · 1 comment
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix P2 Priority 2 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Milestone

Comments

@colin-stubbs
Copy link

Description of Issue/Question

Setup

Using module.run s3.put to place HTML files in an S3 bucket.

Steps to Reproduce Issue

Try using s3.put to place an object into an S3 bucket.
As s3.put has no header argument available the correct Content-Type will not be set, e.g. text/html
The default is binary/octet-stream and this is what is currently set for any objects created using s3.put

Refer to: https://docs.aws.amazon.com/AmazonS3/latest/API/RESTObjectPUT.html

Versions Report

n/a - see pull request diff

@garethgreenaway garethgreenaway added Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix P2 Priority 2 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around labels Sep 16, 2018
@garethgreenaway garethgreenaway added this to the Approved milestone Sep 16, 2018
@garethgreenaway
Copy link
Contributor

@colin-stubbs Thanks for the report and the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix P2 Priority 2 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Projects
None yet
Development

No branches or pull requests

3 participants