More test cases for tracked_fn_return_ref

Author: Veykril

tests/compile-fail/get-set-on-private-input-field.stderr

@@ -15,3 +15,11 @@ error[E0624]: method `set_field` is private
 ...
 15 |     input.set_field(&mut db).to(23);
    |           ^^^^^^^^^ private method
+
+warning: unused import: `salsa::prelude`
+ --> tests/compile-fail/get-set-on-private-input-field.rs:1:5
+  |
+1 | use salsa::prelude::*;
+  |     ^^^^^^^^^^^^^^
+  |
+  = note: `#[warn(unused_imports)]` on by default

tests/compile-fail/tracked_fn_return_ref.rs

@@ -26,4 +26,24 @@ fn tracked_fn_return_struct_containing_ref<'db>(
     }
 }
 
+#[salsa::tracked]
+fn tracked_fn_return_struct_containing_ref_elided_implicit<'db>(
+    db: &'db dyn Db,
+    input: MyInput,
+) -> ContainsRef {
+    ContainsRef {
+        text: input.text(db),
+    }
+}
+
+#[salsa::tracked]
+fn tracked_fn_return_struct_containing_ref_elided_explicit<'db>(
+    db: &'db dyn Db,
+    input: MyInput,
+) -> ContainsRef<'_> {
+    ContainsRef {
+        text: input.text(db),
+    }
+}
+
 fn main() {}

tests/compile-fail/tracked_fn_return_ref.stderr

@@ -1,3 +1,34 @@
+error[E0106]: missing lifetime specifier
+  --> tests/compile-fail/tracked_fn_return_ref.rs:33:6
+   |
+33 | ) -> ContainsRef {
+   |      ^^^^^^^^^^^ expected named lifetime parameter
+   |
+help: consider using the `'db` lifetime
+   |
+33 | ) -> ContainsRef<'db> {
+   |                 +++++
+
+warning: elided lifetime has a name
+  --> tests/compile-fail/tracked_fn_return_ref.rs:33:6
+   |
+30 | fn tracked_fn_return_struct_containing_ref_elided_implicit<'db>(
+   |                                                            --- lifetime `'db` declared here
+...
+33 | ) -> ContainsRef {
+   |      ^^^^^^^^^^^ this elided lifetime gets resolved as `'db`
+   |
+   = note: `#[warn(elided_named_lifetimes)]` on by default
+
+warning: elided lifetime has a name
+  --> tests/compile-fail/tracked_fn_return_ref.rs:43:18
+   |
+40 | fn tracked_fn_return_struct_containing_ref_elided_explicit<'db>(
+   |                                                            --- lifetime `'db` declared here
+...
+43 | ) -> ContainsRef<'_> {
+   |                  ^^ this elided lifetime gets resolved as `'db`
+
 error: lifetime may not live long enough
   --> tests/compile-fail/tracked_fn_return_ref.rs:15:67
    |
@@ -12,3 +43,12 @@ error: lifetime may not live long enough
 ...
 23 | ) -> ContainsRef<'db> {
    |      ^^^^^^^^^^^ requires that `'db` must outlive `'static`
+
+error: lifetime may not live long enough
+  --> tests/compile-fail/tracked_fn_return_ref.rs:43:6
+   |
+40 | fn tracked_fn_return_struct_containing_ref_elided_explicit<'db>(
+   |                                                            --- lifetime `'db` defined here
+...
+43 | ) -> ContainsRef<'_> {
+   |      ^^^^^^^^^^^ requires that `'db` must outlive `'static`

tests/compile-fail/tracked_impl_incompatibles.stderr

@@ -114,11 +114,10 @@ error[E0117]: only traits defined in the current crate can be implemented for ar
    |
 47 | impl<'db> std::default::Default for [MyTracked<'db>; 12] {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------------------
-   |                                     |
-   |                                     this is not defined in the current crate because arrays are always foreign
+   | |                                   |
+   | |                                   this is not defined in the current crate because arrays are always foreign
+   | impl doesn't use only types from inside the current crate
    |
-   = note: impl doesn't have any local type before any uncovered type parameters
-   = note: for more information see https://doc.rust-lang.org/reference/items/implementations.html#orphan-rules
    = note: define and implement a trait or new type instead
 
 error[E0308]: mismatched types