Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove version.js file from Repository #267

Open
awaterma opened this issue Mar 17, 2023 · 1 comment
Open

Remove version.js file from Repository #267

awaterma opened this issue Mar 17, 2023 · 1 comment
Labels
minor We expect this work to be a minor semver change
Milestone
v6

Comments

@awaterma
Copy link
Member

We shouldn't be testing the externalized version against the package.json file; in face we shouldn't have an externalized version outside of the package.json file. So this issue is to resolve that. Why is this required? Can we remove this piece of history from the repository? etc.
@awaterma awaterma added the minor We expect this work to be a minor semver change label Mar 17, 2023
@colincasey
Copy link
Contributor

The version is used when serializing the CookieJar which I'm also not a fan of. If anything, the version of the serialization format should be independent of the library version.

Also, outside of the in-memory store, how useful is it to de/serialize a CookieJar? Storing and loading of data seems like it should be the responsibility of the backing Store implementation.

@wjhsf wjhsf added this to the v6 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
minor We expect this work to be a minor semver change
Projects
None yet
Milestone
v6
Development

No branches or pull requests
3 participants
@colincasey @awaterma @wjhsf