Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect behavior in permuteDomain where domain has a trailing dot #211

Closed
ruoho-sfdc opened this issue Apr 26, 2021 · 0 comments · Fixed by #216
Closed

Incorrect behavior in permuteDomain where domain has a trailing dot #211

ruoho-sfdc opened this issue Apr 26, 2021 · 0 comments · Fixed by #216
Assignees
Milestone

Comments

@ruoho-sfdc
Copy link
Contributor

permuteDomain behaves incorrectly when called with a domain containing a trailing dot:

$ cat strange.js
const tough = require("./lib/cookie");
console.log('Permuting host.example.com.')
console.log(tough.permuteDomain("host.example.com."))
console.log('Permuting host.example.com')
console.log(tough.permuteDomain("host.example.com"))
$ node strange.js
Permuting host.example.com.
[ 'example.com', '.example.com', 'host..example.com' ]
Permuting host.example.com
[ 'example.com', 'host.example.com' ]
@awaterma awaterma added this to the 4.x Release milestone Jun 21, 2021
@awaterma awaterma linked a pull request Sep 27, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants