Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOOT-INF/lib jars are pathed using Bazel internal directory structures #61

Closed
plaird opened this issue Dec 11, 2020 · 3 comments
Closed
Assignees

Comments

@plaird
Copy link
Contributor

plaird commented Dec 11, 2020

Dependency jars should be nested directly under BOOT-INF/lib. But currently we are constructing the spring boot jar with internal details of the build in the form of deeply nested path structures. Spring Boot seems to be able to handle it, but it is poor form.

For maven_install deps, we see paths like:
BOOT-INF/lib/bazel-out/darwin-fastbuild/bin/external/maven/v1/https/nexus-proxy-prd.soma.salesforce.com/nexus/content/groups/public/com/fasterxml/jackson/core/jackson-annotations/2.10.5/jackson-annotations-2.10.5.jar

For internal deps, we see paths like:
BOOT-INF/lib/bazel-out/darwin-fastbuild/bin/projects/libs/acme/blue_lib/liblue_lib.jar

@simontoens
Copy link
Contributor

simontoens commented Dec 11, 2020

@plaird we will have to be careful to handle duplicate names, since there can be targets with the same name under different packages. Not an issue for jars coming from Nexus. Perhaps for internal deps we just keep the root repo path to guarantee uniqueness?

@plaird
Copy link
Contributor Author

plaird commented Dec 12, 2020

Good point @simontoens perhaps we just trim the 'bazel-out/darwin-fastbuild/bin' segment from the path for internal deps.

@plaird
Copy link
Contributor Author

plaird commented Dec 12, 2020

While the algorithm isn't full proof, in most cases the jars in BOOT-INF/lib will now be cleaner. See the PR for more details.

@plaird plaird closed this as completed Dec 12, 2020
@plaird plaird self-assigned this Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants