Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support passing Java args to JVM when Spring Boot application started with Bazel run #36

Closed
plaird opened this issue Jul 29, 2020 · 1 comment
Closed

Support passing Java args to JVM when Spring Boot application started with Bazel run #36

plaird opened this issue Jul 29, 2020 · 1 comment
Assignees
@plaird
Labels
enhancement good first issue

Comments

@plaird
Copy link
Contributor

plaird commented Jul 29, 2020

Allow springboot rule definition in a BUILD file to pass javacopts.
User would like to tweak memory settings for 'bazel run', but this could apply broadly (GC algs, etc).

  • Consider allowing different attributes for the java compilation and the java binary.
  • Can user override BUILD javacopt in a 'bazel run //a/b/c' invocation?
@plaird plaird mentioned this issue Dec 12, 2020
Merged
@plaird plaird self-assigned this Dec 12, 2020
@plaird
Copy link
Contributor Author

plaird commented Dec 12, 2020

This was implemented strictly for bazel run.
Because the java_library is where the java compilation happens, I didn't think it right to do anything else at the springboot level.

@plaird plaird closed this as completed Dec 12, 2020
@plaird plaird changed the title Pass through javacopts to the underlying java rules in the macro Support passing Java args to JVM when Spring Boot application started with Bazel run Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plaird plaird

Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@plaird