Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve Spring Boot rule debugging #148

Closed
plaird opened this issue Jun 13, 2022 · 1 comment
Closed

Fix and improve Spring Boot rule debugging #148

plaird opened this issue Jun 13, 2022 · 1 comment

Comments

@plaird
Copy link
Contributor

plaird commented Jun 13, 2022

First there is a bug in the debug log lines of the springboot packaging bash script:

The env variable name got lowercased in the script by mistake. Since it is a shell variable it should be put back to all caps, as the documentation describes.

Second, we should make the debug log lines in the springboot.bzl an option via an attribute. Create a new attribute debug that is default False.

@plaird
Copy link
Contributor Author

plaird commented Dec 23, 2024

Fixed the first issue - the script detects either lowercase or uppercase options for the foreseeable future. Will remove lowercase support later.

I now disagree with myself for the second. It is nicer for the debug flag to be an env variable, to easily allowing setting and unsetting it without modifying a BUILD file.

@plaird plaird closed this as completed Dec 23, 2024
@plaird plaird added the 2.6.1 label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant