Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Boot packaging script springboot_pkg.sh can fail silently #100

Closed
khogeland opened this issue Apr 13, 2021 · 1 comment
Closed

Spring Boot packaging script springboot_pkg.sh can fail silently #100

khogeland opened this issue Apr 13, 2021 · 1 comment
Labels

Comments

@khogeland
Copy link

The package script should probably set -x, because it will currently continue despite failed commands. For example, if the jar command hits the command length limit, the build will produce a broken jar without any packaged dependencies and the user won't know anything is wrong until they hit runtime classpath issues.

@plaird plaird added the bug label Apr 13, 2021
@plaird
Copy link
Contributor

plaird commented Apr 13, 2021

Good catch.

@plaird plaird changed the title Script fails silently Spring Boot packaging script springboot_pkg.sh can fail silently Apr 13, 2021
@plaird plaird closed this as completed Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants