Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builder): keep absolute paths #255

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

rlodico
Copy link
Contributor

@rlodico rlodico commented Nov 13, 2020

Details

Relative paths do not work later on in Best when the rootDir and the
cwd are not the same because the relative paths are later re-resolved
against the cwd, which points to locations non-existent in the fs

Introduces assertions to existing build output test to validate that the output contains usable paths

Fixes #254

Does this PR introduce a breaking change?

  • Yes
  • No

Relative paths do not work later on in Best when the rootDir and the
cwd are not the same because the relative paths are later re-resolved
against the cwd, which points to locations non-existent in the fs
@diervo
Copy link
Contributor

diervo commented Nov 13, 2020

Is this the only place where we have this issue?

@rlodico
Copy link
Contributor Author

rlodico commented Nov 16, 2020

@diervo I didn't run into any more pathing issues besides this one.

Both a remote agent (with a headless runner) and a local headless runner worked and neither reported pathing issues after the change.

Edit: Looking again, there's actually only ever one usage of benchmarkFolder, and it's the usage that caused my crash in @best/store/src/index.ts#L41. This is where I was originally going to put the fix but if I recall correctly I would have needed to modify the methods to pass in more information than was already available from the result data in order to reconstruct the full path.

@diervo diervo merged commit 03b09cc into salesforce:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmark outputs are missing when cwd is not best project root
2 participants