fix: webdriverio to work with IE11 and other browsers #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineedfat
requested review from
diervo,
jasonsilberman,
jodarove,
nolanlawson and
pmdartus
as code owners
jodarove
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Refactored best/runner-webdriverio code and added rollup-plugin-compat dependency for best/builder to fix IE11 compatibility issues.
In my original best/runner-webdriverio PR, I forgot to include this change in Agent.ts which passes the webdriverOptions to the remote agent worker in agent-hub. Without this change, we aren't able to override the default webdriverOptions which has chrome as the default browser.
Does this PR introduce a breaking change?