-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improving GitHub Checks #182
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonsilberman
force-pushed
the
jsilberman/gh-checks
branch
from
July 26, 2019 18:53
1b3807c
to
6e7de1d
Compare
jasonsilberman
force-pushed
the
jsilberman/gh-checks
branch
from
July 30, 2019 22:26
6e7de1d
to
e491cdb
Compare
⚠ Performance RegressionBest has detected that there is a Please click here to see more details. |
jasonsilberman
requested review from
diervo,
jodarove,
nolanlawson and
pmdartus
as code owners
July 30, 2019 22:56
⚠ Performance RegressionBest has detected that there is a Please click here to see more details. Click to view significantly changed benchmarksbest-benchmark
|
apapko
reviewed
Jul 31, 2019
apapko
reviewed
Jul 31, 2019
@apapko i tried to abstract the similar functions into some generators if you want to take another look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This is a work in progress to improve the GitHub integration with checks and comments.
text
section of check