-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: any number of project configs is processed #114
fix: any number of project configs is processed #114
Conversation
Benchmark resultsBase commit: simple-benchmark-prod
simple-benchmark-compat
lwc-examples-prod
lwc-examples-compat
|
@@ -362,7 +362,7 @@ export async function getConfigs(projectsFromCLIArgs, argv) { | |||
} | |||
} | |||
|
|||
if (projects.length > 1) { | |||
if (projects.length > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember there was a reason for this number, but maybe this is ok.
Could you double check that a project with a default unique config runs just fine?
Otherwise I will try to check later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes this works for both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will merge the pending PRs today or tomorrow.
Benchmark resultsBase commit: simple-benchmark-prod
simple-benchmark-compat
lwc-examples-prod
lwc-examples-compat
|
Details
Config was not correctly processing config files that had a single entry in their project properties. This fixes it so that it will correctly process any number of project entries.
Does this PR introduce a breaking change?