Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(git): update husky with commitlint #110

Merged
merged 5 commits into from
Jun 1, 2018

Conversation

apapko
Copy link
Contributor

@apapko apapko commented May 29, 2018

Details

Use commitlint. Fixes #171

Does this PR introduce a breaking change?

  • Yes
  • No

@apapko apapko requested a review from diervo May 29, 2018 18:58
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: cec6c95 | Target commit: 809b15c

simple-benchmark-prod

object_keys metric base(cec6c95) target(809b15c) trend
stringify_parse duration 35.10 (± 0.20 ms) 37.30 (± 0.30 ms) -6.27% 👎
deep_merge duration 26.60 (± 0.70 ms) 27.65 (± 1.10 ms) -3.95% 👎

simple-benchmark-compat

object_keys metric base(cec6c95) target(809b15c) trend
stringify_parse duration 35.15 (± 0.25 ms) 34.50 (± 0.20 ms) 1.85% 👍
deep_merge duration 112.60 (± 1.85 ms) 111.50 (± 2.50 ms) 0.98% 👍

lwc-examples-prod

simple-item metric base(cec6c95) target(809b15c) trend
create_and_render duration 52.30 (± 0.70 ms) 51.80 (± 0.70 ms) 0.96% 👍

lwc-examples-compat

simple-item metric base(cec6c95) target(809b15c) trend
create_and_render duration 87.20 (± 0.70 ms) 86.20 (± 1.00 ms) 1.15% 👍

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: cec6c95 | Target commit: 234ff60

simple-benchmark-prod

object_keys metric base(cec6c95) target(234ff60) trend
stringify_parse duration 35.10 (± 0.20 ms) 37.30 (± 0.60 ms) -6.27% 👎
deep_merge duration 26.60 (± 0.70 ms) 28.60 (± 1.50 ms) -7.52% 👎

simple-benchmark-compat

object_keys metric base(cec6c95) target(234ff60) trend
stringify_parse duration 35.15 (± 0.25 ms) 35.70 (± 0.30 ms) -1.56% 👎
deep_merge duration 112.60 (± 1.85 ms) 113.50 (± 1.50 ms) -0.80% 👌

lwc-examples-prod

simple-item metric base(cec6c95) target(234ff60) trend
create_and_render duration 52.30 (± 0.70 ms) 52.80 (± 0.80 ms) -0.96% 👎

lwc-examples-compat

simple-item metric base(cec6c95) target(234ff60) trend
create_and_render duration 87.20 (± 0.70 ms) 91.00 (± 3.00 ms) -4.36% 👎

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 2964194 | Target commit: 7cc9ee0

simple-benchmark-prod

object_keys metric base(2964194) target(7cc9ee0) trend
stringify_parse duration 35.00 (± 0.20 ms) 35.70 (± 0.20 ms) -2.00% 👎
deep_merge duration 26.50 (± 1.20 ms) 26.00 (± 0.70 ms) 1.89% 👍

simple-benchmark-compat

object_keys metric base(2964194) target(7cc9ee0) trend
stringify_parse duration 34.20 (± 0.40 ms) 33.30 (± 0.20 ms) 2.63% 👍
deep_merge duration 112.80 (± 1.80 ms) 106.40 (± 1.30 ms) 5.67% 👍

lwc-examples-prod

simple-item metric base(2964194) target(7cc9ee0) trend
create_and_render duration 50.50 (± 0.60 ms) 50.60 (± 0.50 ms) -0.20% 👌

lwc-examples-compat

simple-item metric base(2964194) target(7cc9ee0) trend
create_and_render duration 85.40 (± 1.00 ms) 84.30 (± 0.80 ms) 1.29% 👍

@diervo diervo merged commit 8c7f1f0 into master Jun 1, 2018
@diervo diervo deleted the apapko/semantic-commit-update branch June 1, 2018 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants