Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare and Search views #176

Open
tiiavalt opened this issue Apr 12, 2021 · 0 comments · Fixed by #181
Open

Compare and Search views #176

tiiavalt opened this issue Apr 12, 2021 · 0 comments · Fixed by #181
Assignees
Labels
enhancement New feature or request

Comments

@tiiavalt
Copy link
Contributor

tiiavalt commented Apr 12, 2021

Is your feature request related to a problem? Please describe.
Based on the work that has been done in a previous branch https://github.com/salabs/Epimetheus/tree/feature/comparison-page, create a build comparison view and a search page for builds.

Describe the solution you'd like
Let's bring the old branch up-to-date with develop branch and style the views to fit Epi's styles a bit better.

--
The result

  • Styled the two new views created in a previous branch
  • Changed some props names to camel case

Known issues:

  • Because of accessibility, the search and compare actions must be links and not buttons (they navigate to a different page). Because they're links, they're impossible to disable so current solution is to hide them. Better solution might be that they're plain text when they're supposed to be disabled..?
  • The UI is still quite rough and the page structure is not planned (links to the new views are currently in the header)
  • Comparison view has terrible heading and breadcrumb and they do not include the teams' information, only series' and builds'
@tiiavalt tiiavalt added the enhancement New feature or request label Apr 12, 2021
@tiiavalt tiiavalt self-assigned this Apr 12, 2021
@tiiavalt tiiavalt linked a pull request Apr 13, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant