Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling: Always return instance of 'AuthenticationError' #105

Merged
merged 4 commits into from
Sep 16, 2015
Merged

Error handling: Always return instance of 'AuthenticationError' #105

merged 4 commits into from
Sep 16, 2015

Conversation

fhemberger
Copy link
Contributor

No description provided.

saintedlama added a commit that referenced this pull request Sep 16, 2015
@saintedlama
Merge pull request #105 from opencharterhub/fix/error-handling
e7b4774 
Error handling: Always return instance of 'AuthenticationError'
@saintedlama saintedlama merged commit e7b4774 into saintedlama:master Sep 16, 2015
@fhemberger
Copy link
Contributor Author

Cool, thanks!

@fhemberger
Copy link
Contributor Author

Can you please also push a new version to npm? Should be 3.0.0, as this is a breaking change as well.

@saintedlama
Copy link
Owner

I will do a 2.1.0 version since we used the BadRequestError only so I suspect users to have checked for Error instances only. Good argument?

@fhemberger
Copy link
Contributor Author

Hmm, all error responses containing placeholders were simple objects { message: 'The Error message' }, BadRequestError was only used in 2-3 cases. Also, if people used the options for custom error messages, this will now break in their code.

@saintedlama
Copy link
Owner

Agree will do a 3.x but need to do some code clenaup/stuff before...

@fhemberger
Copy link
Contributor Author

Cool, thanks!

@saintedlama
Copy link
Owner

Changed a lot in the past commits - wanna take a look?

@fhemberger
Copy link
Contributor Author

Haven't tested it yet in detail, but looks good to me at first glance. 👍

@fhemberger
Copy link
Contributor Author

Great, the change works well for me. Ready for the new release. 👍

@fhemberger fhemberger deleted the fix/error-handling branch October 11, 2015 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fhemberger @saintedlama