Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostCard description should probably render markdown #30

Open
tsheinen opened this issue Apr 7, 2024 · 1 comment
Open

PostCard description should probably render markdown #30

tsheinen opened this issue Apr 7, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@tsheinen
Copy link

tsheinen commented Apr 7, 2024

Hi! I think that the PostCard component description should render the description as markdown. This is identical in the default case and comes with a few nice properties like linking and paragraphs in descriptions.

I did a mock-up on my own copy with the https://www.npmjs.com/package/@astropub/md library.

---
import { Markdown } from '@astropub/md'
---

<div class="transition text-75 mb-3.5 prose-base">
    <Markdown of={description} />
</div>

Something like this pretty much just works. Notably, I did add prose-base as a class because the default p margin is 0 and I thought it looked ugly. I'll not make a PR because this is trivial -- I'm very much not a web dev and will leave the styling to you :)

@saicaca
Copy link
Owner

saicaca commented Apr 7, 2024

Thank you for your suggestion, I will consider it.

@saicaca saicaca added the enhancement New feature or request label Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants