SBC-4 support returned but test still failed with "SBC-3 pagelength (>=60) returned but SBC-3 support was not claimed in the standard inquiry page"

[SexyC]

Hi Ronnie,

I happened to find a bug in the following test suite.

Suite: Inquiry

Test: BlockLimits ...    [WARNING] SBC-3 pagelength (>=60) returned but SBC-3 support was not claimed in the standard inquiry page.

I've found that even the SBC-4 is claimed to be supported in the standard inquiry. The BlockLimits will still fail, as SBC-3 was not claimed. Checking the test logic, when SBC-3 is not claimed, we will take it as only support SBC-2. This may not be appropriate.

libiscsi/test-tool/test_inquiry_block_limits.c

Line 84 in 36548b4

/* if it is not SBC3 then we assume it must be SBC2 */

According to the spec of SBC-4, it is compatible to SBC-3. So I think we should pass the test when SBC-4 is claimed while SBC-3 is not.

Thanks!
Best Regards.