Skip to content

Conversation

@gmou3
Copy link
Contributor

@gmou3 gmou3 commented Feb 15, 2024

Changes (mostly in matroid.pyx):

  • Add _iterator functions for bases, circuits, etc, and use them internally (this avoids memory consumption/blowups)
  • Add Whitney numbers functions (for the first and second kind)
  • Correct f_vector definition (the definition up till now referred to the Whitney numbers of second kind)
  • Add characteristic polynomial
  • Correct is_valid function to be False on a negative rank value
  • Optimize circuits function (e.g. sage: %time C = matroids.CompleteGraphic(8).circuits() drops from 4m to 1m)
  • Optimize broken_circuit_complex function
  • Improve docstrings (1-line outputs and other changes)

⌛ Dependencies

@tscrim tscrim self-requested a review February 20, 2024 03:34
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of comments are the same, but I wanted to make a note of them (specifically the sorting). This could potentially generate a lot of merge conflicts, but hopefully that won't be a problem...

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 26, 2024

Overall LGTM

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few more changes to request; minor stuff basically.

@gmou3
Copy link
Contributor Author

gmou3 commented Mar 26, 2024

Thanks to both for the suggestions.

@gmou3 gmou3 requested a review from tscrim April 2, 2024 17:12
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just a few more little things.

@gmou3 gmou3 requested a review from tscrim April 5, 2024 11:29
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thank you. Good to go.

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 5, 2024

@gmou3 You may want to merge #37667 and update the changed pxd files

@github-actions
Copy link

github-actions bot commented Apr 5, 2024

Documentation preview for this PR (built with commit 236361b; changes) is ready! 🎉

@vbraun vbraun merged commit 7855be0 into sagemath:develop Apr 8, 2024
@gmou3 gmou3 deleted the matroid.pyx branch April 8, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants