-
-
Notifications
You must be signed in to change notification settings - Fork 704
Add iterators, Whitney numbers, characteristic polynomial, etc #37361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tscrim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of comments are the same, but I wanted to make a note of them (specifically the sorting). This could potentially generate a lot of merge conflicts, but hopefully that won't be a problem...
|
Overall LGTM |
tscrim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few more changes to request; minor stuff basically.
|
Thanks to both for the suggestions. |
This reverts commit cd652c6.
tscrim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just a few more little things.
tscrim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, thank you. Good to go.
|
Documentation preview for this PR (built with commit 236361b; changes) is ready! 🎉 |
Changes (mostly in
matroid.pyx):_iteratorfunctions forbases,circuits, etc, and use them internally (this avoids memory consumption/blowups)f_vectordefinition (the definition up till now referred to the Whitney numbers of second kind)is_validfunction to beFalseon a negative rank valuecircuitsfunction (e.g.sage: %time C = matroids.CompleteGraphic(8).circuits()drops from4mto1m)broken_circuit_complexfunction⌛ Dependencies