fix expect interface for newer ptyprocess #36339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tornaria
reviewed
Sep 26, 2023
tornaria
reviewed
Sep 26, 2023
See sagemath#32147 for details
Contributor
|
LGTM FWIW, I've been using ptyprocess-0.7.0 with sage for a long time on linux. |
Contributor
|
Also seems to work on conda (as far as this can be checked with the currently broken ci setup) |
Contributor
|
That's a bit quick with the "positive review" here. see #32147 (comment) |
mkoeppe
approved these changes
Sep 27, 2023
Contributor
mkoeppe
left a comment
mkoeppe
left a comment
There was a problem hiding this comment.
This seems to work well, thanks!
|
Documentation preview for this PR (built with commit df89444; changes) is ready! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close #32147
ptyprocess 0.5.2+ included a change that broke our expect.py on macOS
Here we guard a bit more around thrown errors, and this appears to suffice