Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pynac package #32387

Closed
mkoeppe opened this issue Aug 16, 2021 · 11 comments
Closed

Remove pynac package #32387

mkoeppe opened this issue Aug 16, 2021 · 11 comments
Labels
c: packages: standard p: major / 3 t: enhancement
Milestone
sage-9.5

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 16, 2021

The package is obsolete after #32386.

Depends on #32386

CC: @kiwifb @dimpase @jhpalmieri

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: cb57de1

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/32387
@mkoeppe mkoeppe added this to the sage-9.5 milestone Aug 16, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 16, 2021

Branch: u/mkoeppe/remove_pynac_package

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 3, 2021

New commits:

527d5a6build/pkgs/pynac: Remove

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 3, 2021

Commit: 527d5a6

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 3, 2021

Author: Matthias Koeppe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 15, 2021

Changed commit from 527d5a6 to cb57de1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 15, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

e9c8637get_sfunction_from_hash: Add doctest
712f926fix doctest getting source code
97060e9fix docbuild
5d062edone more doctest
3f1ac2esage.symbolic.expression: Merge new_Expression_from_pyobject and new_Expression_force_pyobject
0643756new_Expression_from_pyobject: Add output for new doctests
327ca5fMerge #32407
0d0b58fMerge tag '9.5.beta1' into t/32386/merge_pynac_as_src_sage_symbolic_ginac
b5512c6Merge #32386
cb57de1build/pkgs/pynac: Remove

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 15, 2021

comment:4

Rebased

@jhpalmieri
Copy link
Member

comment:5

Looks okay to me.

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 16, 2021

comment:6

Thanks!

@vbraun
Copy link
Member

vbraun commented Sep 25, 2021

Changed branch from u/mkoeppe/remove_pynac_package to cb57de1

@vbraun vbraun closed this as completed in 5b95747 Sep 25, 2021
@videlec videlec mentioned this issue Feb 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @jhpalmieri @mkoeppe