Do not compare types in coercion model richcmp()

[embray]

Though small, the fix to richcmp is significant and fixes a lot of bugs.

Component: coercion

Keywords: structure coerce

Author: Erik Bray, Jeroen Demeyer

Branch/Commit: de73aad

Reviewer: Jeroen Demeyer, Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/24968

[jdemeyer]

comment:2

I don't like this change. It will make it harder to port Sage to Python 3 by hiding errors in an try/except block.

It would be much better to just not compare types in the first place.

[jdemeyer]

Changed branch from u/embray/python3/sage-structure-coerce to u/jdemeyer/python3/sage-structure-coerce

[embray]

comment:4

If you say so--does this actually break anything?

FWIW I have personally written code before that implements comparisons between metaclasses (!). I don't understand the implications when it comes to Sage though.

---

New commits:

7654b19

Don't compare types at all

[embray]

Changed commit from 082ad7b to 7654b19

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

de73aad

Don't compare types at all

[sagetrac-git]

Changed commit from 7654b19 to de73aad