You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As per #274, (explained here) will revert if the internal Safe transaction fails and both safeTxGas and gasPrice are set to 0.
In this case, it would be very helpful to expose the actual revert message of the failing transaction, so it can be debugged. Currently, the contract just reverts with GS013, which is not in fact helpful in this case.
Proposed solution
Expose the revert message using the following code, or similar:
Use a different method to return the original revert string.
Additional context
Returning GS013 in the case where the internal transaction fails leads to a wild goose change that eventually leads users here. Once a user gets here, it is nearly impossible to find the actual reason for the transaction failing without a long game of guess-and-check.
The text was updated successfully, but these errors were encountered:
froggiedev
changed the title
Expose revert message when
Expose revert message when internal transaction fails and safeTxGas/gasPrice are 0
Dec 13, 2023
Context / issue
As per #274, (explained here) will revert if the internal Safe transaction fails and both
safeTxGas
andgasPrice
are set to 0.In this case, it would be very helpful to expose the actual revert message of the failing transaction, so it can be debugged. Currently, the contract just reverts with
GS013
, which is not in fact helpful in this case.Proposed solution
Expose the revert message using the following code, or similar:
Alternatives
Use a different method to return the original revert string.
Additional context
Returning
GS013
in the case where the internal transaction fails leads to a wild goose change that eventually leads users here. Once a user gets here, it is nearly impossible to find the actual reason for the transaction failing without a long game of guess-and-check.The text was updated successfully, but these errors were encountered: