Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscript out of bounds error #130

Open
savagesr opened this issue Jun 13, 2024 · 10 comments
Open

Subscript out of bounds error #130

savagesr opened this issue Jun 13, 2024 · 10 comments
Assignees
Labels
bug Something isn't working database/omnipath Database (OmniPath) related issues

Comments

@savagesr
Copy link

savagesr commented Jun 13, 2024

Hello,

I am trying to run decoupleR but have just encountered an error after updating to the most recent version today when using run_ulm or run_mlm:

sample_acts <- run_ulm(mat=counts, net=net, .source='source', .target='target', .mor='mor', minsize = 5)
Error in mor_mat[[.target, .source]] <- .weight : 
  [[ ]] subscript out of bounds

I first encountered the error on my data but it also occurred for me when exactly following the tutorial on "Transcription factor activity inference in bulk RNA-seq".

I am using OmnipathR version 3.13.5 and decoupleR 2.9.7.

@PauBadiaM PauBadiaM self-assigned this Jun 14, 2024
@PauBadiaM PauBadiaM added the bug Something isn't working label Jun 14, 2024
@PauBadiaM
Copy link
Member

Hi @savagesr,

Thanks for opening this issue. I've checked and this error is because of a new bug from OmnipathR that introduces NAs in the network when calling get_collectri. @deeenes, something went wrong with the new update and now all sources that come from a complex return NAs, could you have a look?

@PauBadiaM PauBadiaM added the database/omnipath Database (OmniPath) related issues label Jun 14, 2024
@Sigmatilde
Copy link

I encountered the same error, after removing the rows of net with NA the command run_ulm is working. thank you!

@PauBadiaM
Copy link
Member

@deeenes any update on this issue? I've checked and it is only the R version of omnipath, the python version works fine.

@JenMcKey
Copy link

JenMcKey commented Jul 4, 2024

Hi!
I'm encountering the same error, but removing NAs from net (using drop_na()) doesn't solve it for me. Any ideas what I can try? I'm also using OmnipathR 3.13.5 and decoupleR 2.9.7.
Thank you!

@thekingofall
Copy link

thank you
net2 <- subset(net, !is.na(source) & !is.na(target))
acts <- run_ulm(mat=mat, net=net2, .source='source', .target='target',
.mor='mor', minsize = 5)

it works

@JenMcKey
Copy link

JenMcKey commented Jul 4, 2024

Yes, that worked. Thank you so much @thekingofall!

@PauBadiaM
Copy link
Member

@deeenes any update on this error?

@PauBadiaM
Copy link
Member

@deeenes has this been fixed?

@PauBadiaM
Copy link
Member

@deeenes any update?

@deeenes
Copy link
Member

deeenes commented Aug 7, 2024

Hi all, apologies for the late reply!

With OmnipathR 3.13.8 this issue should be fixed. Please update from our git repo:

library(remotes)
remotes::install_github('saezlab/OmnipathR')

Sorry in advance if anything else got broken, there are quite some updates in this release. If you see any error, ping me here and I'll fix it quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working database/omnipath Database (OmniPath) related issues
Projects
None yet
Development

No branches or pull requests

6 participants