Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A connection to https://i.ytimg.com/ was leaked #19

Closed
sadr0b0t opened this issue Oct 3, 2020 · 3 comments
Closed

A connection to https://i.ytimg.com/ was leaked #19

sadr0b0t opened this issue Oct 3, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@sadr0b0t
Copy link
Owner

sadr0b0t commented Oct 3, 2020

При прокрутке списков с картинками в лог массово сыпется предупреждение:

2020-10-04 00:57:03.718 6066-6099/su.sadrobot.yashlang W/OkHttpClient: A connection to https://i.ytimg.com/ was leaked. Did you forget to close a response body?
  1. Предупреждение идет 100% из VideoThumbManager.loadBitmap (если убрать подключение к сети и возвращать вместо картинки null, то сообщение исчезает)

  2. Сообщение, судя по всему, идет от успешно загруженных картинок (на главном экране они сыпятся массово, на экране удаленного канала Союзмультфильм их почти нет), но не от всех и это не точно.

@sadr0b0t sadr0b0t added the bug Something isn't working label Oct 3, 2020
@sadr0b0t
Copy link
Owner Author

sadr0b0t commented Oct 3, 2020

пишут, что в некоторых ситуациях это может быть не проблема приложения, а платформы, и в каких-то версиях okhttp это исправили даже

https://android-review.googlesource.com/c/platform/external/okhttp/+/460418
square/okhttp#2311
square/okhttp#2843
square/okhttp#4399
google/ExoPlayer#3726

@sadr0b0t
Copy link
Owner Author

sadr0b0t commented Oct 3, 2020

Закрытие подключения внутри finally не помогло:
4b54211

@sadr0b0t
Copy link
Owner Author

sadr0b0t commented Oct 4, 2020

фикс: 23a309e

подробности: #17 (comment)

@sadr0b0t sadr0b0t closed this as completed Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant