Ships lock.m4 with missing dependencies

[rossburton]

m4/lock.m4 uses gl_PTHREAD_RWLOCK_RDLOCK_PREFER_WRITER but nothing provides that function. For some reason this is only causing problems when I build parted, maybe that function ends up being pulled into most builds?

[rossburton]

Confirmed that dropping http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob;f=m4/pthread_rwlock_rdlock.m4;h=87886a3b10f1230e3944b4136e5a113900d08e4e;hb=HEAD into /usr/share/gettext-tiny/m4/ fixes this.

[xhebox]

i can not reproduce the issue. i built parted-3.3 with './configure' and 'autoreconf'. could you provide more details about the failure?

EDIT: btw, i'm using musl-libc, maybe that's the cause.

[rossburton]

Maybe thats the difference, yes.

You can verify this easily enough without actually building anything. m4/lock.m4 uses gl_PTHREAD_RWLOCK_RDLOCK_PREFER_WRITER but nothing in gettext-tiny defines that, and the gl_ prefix indicates it's part of gnulib. Ergo, unless you have that macro provided by something else, it's undefined.

[xhebox]

@rossburton after some survey, here's my thought:
this file belongs to gnulib. and gettext should not ship with it(the gnu gettext does not include it too).

there must be some steps missing in your building process. when generating './configure', autotools should copy pthread_rwlock_rdlock.m4 into that directory.

it should be a wont fix problem, or it's not a bug of gettext-tiny. close the issue, if you are satisfied with the answer.

EDIT: you can check by touching a newconfigure.ac:

AM_GNU_GETTEXT_VERSION(0.18.2)

then use autopoint from gnu to see that.

[rofl0r]

this file belongs to gnulib. and gettext should not ship with it(the gnu gettext does not include it too).

well, we copied gnulib m4 files into place to make autopoint work:
20c2491

so it's well possible that a file was overlooked, in which case we should add the missing one, but from roughly the same point in time of when gnulib files were imported so the stuff matches.