Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a shared dir in tests for common functions between merkle lockup contracts #1001

Closed
andreivladbrg opened this issue May 7, 2024 · 1 comment
Closed

Add a shared dir in tests for common functions between merkle lockup contracts #1001

andreivladbrg opened this issue May 7, 2024 · 1 comment
Labels
effort: medium Default level of effort. priority: 3 Nice-to-have. Willing to ship without this. type: test Adding, updating, or removing tests. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@andreivladbrg
Copy link
Member

andreivladbrg commented May 7, 2024 •
edited by smol-ninja

Ref #1000 (comment)

The idea is to do something similar to how core tests are structured: https://github.com/sablier-labs/v2-core/tree/staging/test/core/integration/concrete/lockup
@andreivladbrg andreivladbrg added effort: medium Default level of effort. priority: 3 Nice-to-have. Willing to ship without this. type: test Adding, updating, or removing tests. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. labels May 7, 2024
@smol-ninja smol-ninja transferred this issue from sablier-labs/v2-periphery Jul 30, 2024
@smol-ninja
Copy link
Member

Duplicate of #1002.

@smol-ninja smol-ninja closed this as not planned Won't fix, can't repro, duplicate, stale Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: medium Default level of effort. priority: 3 Nice-to-have. Willing to ship without this. type: test Adding, updating, or removing tests. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smol-ninja @andreivladbrg and others