-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Vercel Analytics #131
Comments
We would have to implement a cookie banner to enable these analytics, wouldn't we, @razgraf, @gavriliumircea? |
Yus but we should use the cookie banner that we already have |
Got it. Would it be difficult to port that over to this repository? Related: https://github.com/sablier-labs/v2-interfaces/discussions/454 |
First of all we don't actually have a roadmap for the sdk. Further more we will be able to put there the component itself but the entire cookies system is a different discussion, we have a store related to those, config function, project keys so the complexity is increasing exponentially. |
I know. When I add related links, I just put it there for historical association reasons - not to push it as a high-priority item today.
Surely we can have a minimal component just for the Vercel analytics and Crisp? We don't need Sentry and Mixpanel and the other stuff in the docs. Maybe Docusaurus has a pre-fab solution for cookies? More research needed. |
We should discuss this in the call we have next week. |
Worth noting that the SDK isn't very related to this discussion. The SDK would include Sablier branded elements (UI or flows) for integrators to use. The "legal" components like any other very opinionated functionalities (like the cookie banner) would most likely not live in an SDK. Maybe in a shared internal components package (but we have that for now in the interfaces monorepo). Looks like Vercel Analytics should be valid for an integration with Docusaurus. There's still the question of what the best approach is e.g., injecting the Related links: |
You're right.
Nice |
The text was updated successfully, but these errors were encountered: