Notes become unaccessible when moving fails

[ZebraVogel94349]

Before submitting an issue, please check the following

• I have searched for similar issues (both open and closed) and cannot find a duplicate
• I agree to follow the Code of Conduct

Describe the bug

I just updated Saber to 0.21.4 and changed directory where notes are stored on Android. In one folder I had a glitched note with the name '/', which got created due to the bug described in #1213. Because of that, I know have a bunch of folders containing other folders as my Saber directory and can't access any of my notes, which are still in /data/data/com.adilhanney.saber/ and didn't get moved. Please make it possible to change the saber directory back to the default one, even though it still has notes in it.

Edit: I just noticed that this isn't caused by notes called '/' but that it is a general problem. I just created a directory called 'Test' with one note in it and changed the directory to something in the internal storage. Now I have Test/Test/Test/Test... and can't access the note anymore. I also can't change it back to the default directory.

Edit 2: I was able to recover my notes by downgrading the app via adb with the command adb install -d Saber_v0.21.2.apk. However, I can't update the app again without reinstalling it completely, because the new directory is still stored in the settings. I'm using the APK file from Github. I don't know what happens, if you have previously installed the app from the Playstore or from F-Droid and run that command. It could result in a permanent loss of all notes.

To reproduce

1. Create a directory with the name 'Test'
2. Add a note to the directory
3. Go to settings and change the saber directory
4. The app tries to recursively copy all notes, resulting in the app to crash
5. The new directory doesn't contain any notes. They are as far as I know still in the default one.

Expected behavior

Migrate the directories correctly. Revert the directory change if migrating fails.

Saber version

v.0.21.4

Device

• Device: Samsung Galaxy Tab S7 FE
• OS: Android 14

Anything else?

No response

[ZebraVogel94349]

I just made a quick fix to this by making it possible to change the directory to one that is not empty and then just not moving anything. The fix is in #1229