-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Generalized version of this mod #46
Comments
for 1) for 2) edit: |
Well, dynamic items are possible as shown here https://youtu.be/bD6PSBtQwww Hopefully blocks might be possible with this? https://github.com/lukebemishprojects/DynamicAssetGenerator For crafting this tech might work https://old.reddit.com/r/MinecraftCommands/comments/nwqkrw/nbt_crafting_in_the_vanilla_crafting_table_is/h1ailij/ Alternative for crafting maybe add some mixins into the crafting table GUI update, so if it's all filled it generates the item (if not already cached) and places it into the grab-slot Edit: also for me personally a compressor block would be totally fine. ngl it feel like it would be more balanced if the crafter itself had to be compressed, so like a N-compressed crafting table can craft up to 2N-compressed items; just a thought |
For items and crafting: it wont work, as it is as i mentioned a "hacky" way to do it and it will mess up a lot (for example: stacks can not be tracked as mentioned by the creator) For the generator: Last time i wanted to use a lib the lib didn't have any doc at all and i didn't want to go through the entire source code to see what does what etc. Maybe I'll have a look at this one For Mixins: Using them especially for modifying the crafting system can mess up a lot and will likely break any mod that access the classes i have to modify You have to be careful with mixins, however be noted that I didn't use them by myself yet, only seen other devs talking about the mixin hell Having a compressor chain is kinda overkill imo tbh (as i understood it: Compressor for c1, Double compressor for c2 ... Giga Compressor for c10) if at all, one compressor should be enough Edit: |
Hey, so this mod is great and is very useful. However I think a better approach would to programmatically scan, and according to some rules (i.e. "only blocks") create compressed variants. This would make it automatically extend for all minecraft and modded blocks. Another suggestion is instead of new items being registered perhaps you could have a "base" compressed item who's information & text are stored in the tags to avoid pages of item managers being filled with compressed variants of things.
The text was updated successfully, but these errors were encountered: