Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename upload/directory to upload/app #23

Open
pcfreak30 opened this issue Jan 18, 2024 · 4 comments
Open

Rename upload/directory to upload/app #23

pcfreak30 opened this issue Jan 18, 2024 · 4 comments

Comments

@pcfreak30
Copy link

Given directory support is being/has been built, s5/upload/directory no longer makes sense for an app.

It should be s5/upload/app.

@parajbs
Copy link

parajbs commented Jan 18, 2024

hello pcfreak30,

If the function behind "s5/upload/directory" doesn't change because I also upload directories.
e.g.:
cid.s5server.com/image/

and there are images from "1.jpg" to "100.jpg", which I can then access using cid and path to image.
because I can get path via metadata.
There is no "index.html" like in an app.

Whether it's called "s5/upload/directory" or "s5/upload/app" doesn't matter.

@pcfreak30
Copy link
Author

hello pcfreak30,

If the function behind "s5/upload/directory" doesn't change because I also upload directories. e.g.: cid.s5server.com/image/

and there are images from "1.jpg" to "100.jpg", which I can then access using cid and path to image. because I can get path via metadata. There is no "index.html" like in an app.

Whether it's called "s5/upload/directory" or "s5/upload/app" doesn't matter.

If you want to use that endpoint to create a public directory, it does. Based on common sense, the name doesn't match the purpose/intent.

@redsolver
Copy link
Collaborator

@pcfreak30 how would you feel about POST /s5/upload/webapp ?

@pcfreak30
Copy link
Author

@redsolver That works. Just need to keep these distinct. Can add more endpoints as needed in the future too, like /media.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants