-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Endpoints for Metrics and Probes #91
Comments
Great idea. I also find a async version of the prometheus client library. I think I will start with the health check... |
I implemented a first For the health check, I will evaluate the processing time of the messages. This should actually be quite simple and centralized. At the moment I use the port 8127 for the http server. Or should we use Port 8080 to make clear that it is a http server? |
This looks good, all http codes between 200 and below 400 are considered success, so 503 will get recognized as failed.
The Port could be any number above 1024 that's not used for a common service, so 8127 works fine i think. considering that host network is often used in smaller setups and using an uncommon port helps users to prevent port duplications. In every other environment port mapping/ distinct service ips should prevent any collisions. Thanks for your effort, let me know if i can help test anything. Regards, |
Use Case:
Design Proposal:
Open Points:
Based on this discussion
Edit: Added Open Points
The text was updated successfully, but these errors were encountered: