Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1331: Fix importlib module import error that resulted in inconsistent std library usage #1332

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Issue 1331: Fix importlib module import error that resulted in inconsistent std library usage #1332

merged 3 commits into from
Oct 23, 2024

Conversation

ivenzor
Copy link
Contributor

@ivenzor ivenzor commented Oct 23, 2024 •
edited
Loading

Change importlib_metadata to importlib.metadata in __init__.py , added additional comments for clarity.

@ivenzor ivenzor mentioned this pull request Oct 23, 2024
Closed
jpl-jengelke
jpl-jengelke approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@jpl-jengelke jpl-jengelke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks for fixing this haunting glitch that surely reared its head unknowingly several times. And we really appreciate the thorough documentation.

@jpl-jengelke jpl-jengelke self-assigned this Oct 23, 2024
@jpl-jengelke jpl-jengelke changed the title PR to fix Issue 1331 Issue 1331: Fix importlib module import error that resulted in inconsistent std library usage Oct 23, 2024
@jpl-jengelke
Copy link
Collaborator

Verified that this prioritizes the Python Standard Library version of metadata.

@jpl-jengelke jpl-jengelke merged commit 96e9924 into rzellem:develop Oct 23, 2024
@ivenzor ivenzor deleted the issue_1331 branch October 23, 2024 06:11
@tamimfatahi tamimfatahi linked an issue Oct 25, 2024 that may be closed by this pull request
Python 3.12 ModuleNotFoundError: No module named 'importlib_metadata' #1331
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpl-jengelke jpl-jengelke jpl-jengelke approved these changes

@rzellem rzellem Awaiting requested review from rzellem

@tamimfatahi tamimfatahi Awaiting requested review from tamimfatahi

Assignees

@jpl-jengelke jpl-jengelke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.12 ModuleNotFoundError: No module named 'importlib_metadata'
3 participants
@ivenzor @jpl-jengelke @rzellem