Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor bug fixes and unified filter detection #1215

Merged
merged 3 commits into from
Aug 8, 2023
Merged

Minor bug fixes and unified filter detection #1215

merged 3 commits into from
Aug 8, 2023

Conversation

jpl-jengelke
Copy link
Collaborator

  • Limit loose filter description matching
  • Bug fix involving name detection
  • Break out reserved filter abbreviations into class-level variables
  • Other minor improvements and bug fixes

Closes #1210

rzellem and others added 3 commits August 6, 2023 19:40
@jpl-jengelke jpl-jengelke self-assigned this Aug 8, 2023
tamimfatahi
tamimfatahi approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@tamimfatahi tamimfatahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tamimfatahi tamimfatahi merged commit 416b048 into develop Aug 8, 2023
@jpl-jengelke jpl-jengelke changed the title Minor bug fixes and unity in filter detection Minor bug fixes and unified filter detection Aug 8, 2023
@jpl-jengelke jpl-jengelke mentioned this pull request Aug 8, 2023
Merged
@jpl-jengelke jpl-jengelke deleted the issue_1210 branch September 3, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamimfatahi tamimfatahi tamimfatahi approved these changes

Assignees

@jpl-jengelke jpl-jengelke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpl-jengelke @tamimfatahi @rzellem