Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter logic modifications to extend matching #1211

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Filter logic modifications to extend matching #1211

merged 2 commits into from
Aug 7, 2023

Conversation

jpl-jengelke
Copy link
Collaborator

@jpl-jengelke jpl-jengelke commented Aug 5, 2023 •
edited
Loading

Closes #1210

  • Remove redundancy in naming by auto-generating some value data
  • Modify LimbDarkening OOP design to utilize static methods and create appropriate class variables
  • Create matcher map to match against punctuation free and spacing normalized user input variables
  • Extend filter matching to algorithmically examine filter inputs step-wise from most- to least-critical
    • Add name option to input filter
  • Modify instance setters to set instance filters from class variables

@jpl-jengelke
Issue #1210: Updated filters to remove redundancy in naming which is …
d43e3df 
…auto-generated now as a convenience function. ...
@jpl-jengelke jpl-jengelke self-assigned this Aug 5, 2023
@jpl-jengelke jpl-jengelke changed the base branch from main to develop August 5, 2023 00:40
@jpl-jengelke
Closes #1210: Implement fuller validation techniques on filter specif…
a1e070d 
…ications. OOP design changes to support class and static methods. ...
@jpl-jengelke jpl-jengelke marked this pull request as ready for review August 6, 2023 23:04
@jpl-jengelke
Copy link
Collaborator Author

Tested on my local workstation and passed. ...

@jpl-jengelke jpl-jengelke linked an issue Aug 6, 2023 that may be closed by this pull request
Extend filter matching for malformed values #1210
Closed
@rzellem rzellem merged commit e4b1a97 into develop Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzellem rzellem rzellem approved these changes

@tamimfatahi tamimfatahi Awaiting requested review from tamimfatahi

@pearsonkyle pearsonkyle Awaiting requested review from pearsonkyle

Assignees

@jpl-jengelke jpl-jengelke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend filter matching for malformed values
2 participants
@jpl-jengelke @rzellem