Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log file sometimes not made #458

Open
rzellem opened this issue Dec 9, 2020 · 10 comments
Open

Log file sometimes not made #458

rzellem opened this issue Dec 9, 2020 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@rzellem
Copy link
Owner

rzellem commented Dec 9, 2020

For some users, even when using the latest version of EXOTIC, the log file is not being made. Is it hiding somewhere or is there a more evil problem lurking about?

@rzellem rzellem added the bug Something isn't working label Dec 9, 2020
@tamimfatahi
Copy link
Collaborator

tamimfatahi commented Dec 9, 2020

Do you know who specifically? Maybe we can get in touch with them. Generally, log files should be created in the same directory they launch exotic.py from (at least for me). I've also noticed it goes into other folders as well, but that could just be me because I'm launching it in different directories as well when I use my IDE or terminal.

@rzellem
Copy link
Owner Author

rzellem commented Dec 9, 2020

Right now, just @pearsonkyle

@jpl-jengelke
Copy link
Collaborator

jpl-jengelke commented Dec 10, 2020 via email

@rzellem
Copy link
Owner Author

rzellem commented Dec 10, 2020

@jpl-jengelke - So if a user installs via pip install exotic, the log file will not be written?

@jpl-jengelke
Copy link
Collaborator

It will be written, just not easy to find. I think we need to specify a default directory somewhere but it won't necessarily be in the directory where it is running. What we could do is detect if it is running as a module and then change the log file location to /logs/ (be sure to make the dir first.

https://stackoverflow.com/a/57977441/325452
https://stackoverflow.com/q/14050281/325452

@rzellem
Copy link
Owner Author

rzellem commented Dec 10, 2020

Is this something you'd like to tackle, @jpl-jengelke, after next week's roll-out of CITISENS? or could @pearsonkyle help you out here?

@jpl-jengelke
Copy link
Collaborator

Given the LOE to get into all the logging minutiae, it's probably better if I do it. I can let you know next week. ...

@jpl-jengelke
Copy link
Collaborator

I assigned this to Tamim and myself (only based on earlier comments) as it seems the work is taking place right now.

@tamimfatahi
Copy link
Collaborator

tamimfatahi commented May 12, 2021

Adding onto this issue that not all logging files appear to be getting timestamps. Could be due to OS possibly as the error resulted from Ubuntu 20.04/WSL2/Windows 10, Python 3.8.5.

@tamimfatahi
Copy link
Collaborator

@jpl-jengelke What's the status on this? Is this still an issue we should deal with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants