Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comparison Star falls off detector #1005

Closed
tamimfatahi opened this issue Jul 5, 2022 · 2 comments · Fixed by #1079
Closed

Comparison Star falls off detector #1005

tamimfatahi opened this issue Jul 5, 2022 · 2 comments · Fixed by #1079
Assignees
@tamimfatahi
Labels
bug Something isn't working

Comments

@tamimfatahi
Copy link
Collaborator

If the comparison star exists in the first image but not later on, modify the code to prevent it from erroring as shown here.
@tamimfatahi tamimfatahi added the bug Something isn't working label Jul 5, 2022
@tamimfatahi tamimfatahi self-assigned this Jul 5, 2022
@tamimfatahi
Copy link
Collaborator Author

Make this also work for the target star.

@tamimfatahi tamimfatahi mentioned this issue Sep 28, 2022
Closed
@tamimfatahi tamimfatahi mentioned this issue Oct 28, 2022
Merged
@tamimfatahi tamimfatahi linked a pull request Oct 28, 2022 that will close this issue
Issue 1005 & 1073: Bypassing comp stars that fall of detector & adding Rp/R* to AAVSO priors #1079
Merged
@tamimfatahi
Copy link
Collaborator Author

Completed in PR #1079

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tamimfatahi tamimfatahi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@tamimfatahi