Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding the example to nextjs #37

Open
Deep-Codes opened this issue Apr 6, 2021 · 7 comments
Open

adding the example to nextjs #37

Deep-Codes opened this issue Apr 6, 2021 · 7 comments

Comments

@Deep-Codes
Copy link

Hey!

is it possible to add this example in nextjs/examples

There seems to be no example for rescript.

@ghost
Copy link

ghost commented Apr 6, 2021

I would keep a very minimal example there, so that ReScript gets regression test coverage, but keep housing the full project here.

@Deep-Codes
Copy link
Author

Yep correct

@jihchi
Copy link

jihchi commented Apr 7, 2021

FYI. I found there is an example of ReasonML & ReasonReact
https://github.com/vercel/next.js/tree/canary/examples/with-reasonml

It would be great if we have an example for ReScript (rescript-react)

@ryyppy
Copy link
Owner

ryyppy commented May 6, 2021

Oh... IMO the ReasonML template should be removed completely, since starting a NextJS / ReScript project with Reason is like writing a legacy codebase from scratch.

@ryyppy
Copy link
Owner

ryyppy commented May 7, 2021

Okay, did my part and created two PRs to upgrade the examples:

Last one missing is reason-relay -> rescript-relay, but I have not used that one so far.

@danwetherald
Copy link

Last one missing is reason-relay -> rescript-relay, but I have not used that one so far.

@zth - Maybe you can help with this?

@ryyppy
Copy link
Owner

ryyppy commented Jun 10, 2021

@dan003400 Already talked to Gabriel about this.. there's currently no bandwidth on his side to update that one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants