-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: overhaul issue templates #1667
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the nice PR!
This looks very good! I have two comments, though:
- In the bug report terminal emulator field the text gets truncated (in your screenshots as well as in my tests); of course this depends on the actually used fonts etc, but maybe we should make it a bit shorter.
I would suggest usingkitty
instead ofgnome-terminal
, which probably fits and according to the issue frequency is more used. - The checkboxes are now all mandatory, which means you can not press the submit button until all checkboxes are ticked.
I guess when people are honest and did not do all the stuff, and then want to submit, they just tick the other ones, because, well, it is required. Maybe it is better to let these non-required to get honest answers to the questions. Of course they should all be checked but just forcing people to check them can have diametrical effects I fear?
What do you think?
@allcontributors please add @gu5e for doc |
I've put up a pull request to add @gu5e! 🎉 |
I would also add these comments somehow, because frequently people do not add screenshots at all (which makes reproduction very hard) or snip just a very small fraction of the screen...
Previously this section has been called 'Screenshots' explicitely, for the same reasons: |
I have tried to address most of the things you pointed out @Finii (sorry for the accidental ticking btw, ill be sure to do it next time) |
:-D no problem at all, ppl do it all the time Thanks for the PR, I will fix one small thing an then merge. |
[why] Make sure the examples are understood correctly and add some more info. Signed-off-by: Fini Jastrow <[email protected]>
Thank you! 💚 |
Description
This PR overhauled the issue templates. It changed them to issue template forms and fixed mistakes and consistency.
Requirements / Checklist
Issue number where discussion took place: #xxx
What does this Pull Request (PR) do?
This PR changes the format of the issue templates and fixes mistakes.
How should this be manually tested?
It can be manually tested by clicking the New Issue button in the Issues tab and selecting one of the categories
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)