Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need for a new font-patcher script #97

Closed
mhartington opened this issue Jul 26, 2016 · 3 comments
Closed

Need for a new font-patcher script #97

mhartington opened this issue Jul 26, 2016 · 3 comments

Comments

@mhartington
Copy link

Subject of the issue

Patching fonts with ligatures
Describe issue here
With ligatures kind of being a more common thing, it's good idea to support them. Iterm 2 nightly has support for ligatures, but it needs to be whitelisted. There might be a need for a new font-patch script that doesn't modify the fonts name and postscript meta data. So once the fonts get generated, it can be consumed by iterm without any issues.


    PostScript name HaskligNerdFontPlusFontAwesomePlusOcticonsPlusPomicons---Regular
    Full name   Hasklig Nerd Font Plus Font Awesome Plus Octicons Plus Pomicons
    Family  Hasklig Nerd Font
    Style   Regular
    Kind    OpenType PostScript

Not sure what the licensing would be for this. It may be that the script would need to be added but not the fonts. I assume you're renaming these fonts for licensing reasons.

See this line here

Your Setup

  • Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)?

any font with ligatures 😁

  • Which terminal emulator are you using (e.g. iterm2, urxvt, gnome, konsole)?

iterm 2 nightly

  • Are you using OS X, Linux or Windows? And which specific version or distribution?

macOS beta

Let me know if there's anymore info/help needed.

@ryanoasis
Copy link
Owner

@mhartington Hey thanks, yeah I agree it would be cool and even useful to support ligatures. By the way related to this would be #57

I know this repo has been a bit quiet lately but yes I would and do appreciate any help or effort into improving.

E.g. there has been a fairly substantial alternate patching proposal in #83 but I just haven't gotten to trying it out or providing much thought 😢

from @be5invis:

This script preserves all metadata from the original font, therefore it shares the compatibility of the original font.

I assume you're renaming these fonts for licensing reasons.

Yes exactly the current reason 😈

So in summary I am totally for getting ligatures supported or at the very least not be butchered by the current patcher

@mhartington
Copy link
Author

Very good! 😁

I shall move the talk over to those other issues and try to make a new PR

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants