FiraCode NF Retina not being recognized as a distinct font

[mtsitzer]

I'm seeing an issue with FiraCode NF Retina not being recognized as a distinct font.

After installing FiraCode NF (all faces), I see this:

This suggests its part of the FiraCode NF Family

But when I go into the fonts folder, I don't see Retina as a distinct font, nor do I see it as part of the family

Compare this with the standard (non Nerd Font) Fira Code:

Also, why does the standard Fira Code install give me specific font face options but FiraCode NF is singluar?
In MS Word:

Originally posted by @mtsitzer in #440 (comment)

[Finii]

Word would be fixed with #717, at the moment the font grouping is wrong and all weights get the same name 😒

The Retina is not a separate font in the Fira we have in the src/unpatched-fonts/ I believe. Where exactly did you download your Fira-Originals?

If Retina has to be a different face, this could be fixed, but the original Fira I have does not suggest that.

See #717's name_parser_test2.known_issues line 82ff, the lines with - are current patching, the > are original font, + how it should look like.

Edit: Add last paragraph and image

[mtsitzer]

I got the originals from https://github.com/tonsky/FiraCode

[Finii]

Hmm, 6.2 has this naming scheme:

Retina is no other typographic Family here. It's also not called 'Retina Medium'; not sure why it turns up as such in your font folder (never looked into the font folder).

Apart from grouping, you real issue is that you can not access 'Retina' in VS, right?

[mtsitzer]

Correct --- and in other applications as well (such as Word, Windows Terminal, etc.)

Interestingly, I'm checking on another PC (with Fira Code 5.2 Installed), and I see the same breakdown

[Finii]

They (Fira) say Retina is a weight ;-)

I personally have no clue what Retina means.

[mtsitzer]

Here's some description for Retina:
tonsky/FiraCode#872 (comment)

[Finii]

Correct --- and in other applications as well (such as Word, Windows Terminal, etc.)

Unfortunately the fix is ... not hard but involves changing a lot fonts. In principle the PR (#717) is ready but I wanted to add more documentation and explanation stuff.

If you can self patch, maybe use that branch (git checkout feature/rewrite-setup_font_names) and patch with --parser given to font-patcher. That will result in more accurate naming...

[Finii]

Here's some description for Retina

Ah great! Thank you!

So Retina is the Apple-Fanboy name for Book :-D

[mtsitzer]

I'm good to wait for you to finalize 717. I just followed the rabbit hole a littler further than I'd intended, and figured I should make an issue out of it.

As for the "Retina" name --- yeah, I guess so (I don't use any apple products haha).

[Finii]

Self-Patch this with --makegroups.
This will be the repo wide default with v3.0.0.

[github-actions]

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.