Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hope to add Sarasa-Gothic(更纱黑体) #587

Closed
DustinWin opened this issue Mar 4, 2021 · 17 comments
Closed

Hope to add Sarasa-Gothic(更纱黑体) #587

DustinWin opened this issue Mar 4, 2021 · 17 comments
Labels
❲Aa❳ new font keep_unlocked Allow discuissions for extended time even after closing

Comments

@DustinWin
Copy link

Hope to add Sarasa-Gothic(https://github.com/be5invis/Sarasa-Gothic). When displaying Chinese, the font size can be matched with English.
Use Sarasa-Gothic:
QQ截图20210305040617
Use JetBrainsMono NF:
QQ截图20210305040650
It can be seen that when the JetBrainsMono NF is used, Chinese is squashed up and down.

Thans!

@folliehiyuki
Copy link
Contributor

I don't think this is gonna be accepted. Sarasa has so many flavors, and its counterpart (Iosevka) already is here.

@DustinWin
Copy link
Author

I don't think this is gonna be accepted. Sarasa has so many flavors, and its counterpart (Iosevka) already is here.
I tried to install Iosevka, and found that the font can be set in PowerShell, but the Chinese is garbled and the "code page"(代码页) needs to be changed. The font cannot be selected in cmd.

@MountComb
Copy link

When mixing CJK and Latin characters, a “monospace” font providing exactly 2:1 CJK to Latin character width would be needed for proper character alignment.

Unfortunately, Sarasa Gothic is the only option as far as I know. Iosevka does not provide CJK characters.

If it's difficult to supporting all Sarasa Gothic flavors, adding only the Term or Mono flavor would be of great help.

@ChiefMikeK
Copy link

ChiefMikeK commented Jun 21, 2021

I though Iosevka features - Wikipedia included DOUBLE WIDTH MONO CJK

I GUESS THE WIKIPEDIA PAGE NEEDS AN UPDATE :neckbeard:

@ifplusor
Copy link

ifplusor commented Dec 1, 2021

@DustinWin I think you can try Sarasa-Gothic-Nerd-Fonts

@zhiyuanzhai
Copy link

I think you can try Sarasa-Gothic-Nerd-Fonts

@ifplusor That project excludes material design icons.

@DustinWin
Copy link
Author

@DustinWin I think you can try Sarasa-Gothic-Nerd-Fonts

Thans!

@Finii
Copy link
Collaborator

Finii commented Oct 28, 2022

The material design icons will be moved (for exactly that reason), see

Funny, https://github.com/jonz94/Sarasa-Gothic-Nerd-Fonts takes Delugia's workflow :-D
But it still takes Nerd Fonts v2.1; I updated Delugia in the meantime to v2.2.2.

@Finii Finii added this to the v3.0.0 milestone Oct 28, 2022
@Finii
Copy link
Collaborator

Finii commented Oct 28, 2022

If I see this correctly they have

Sarasa | Gothic     | CL | Extralight | -         
       | Fixed      | HC | Light      | Italic
       | Fixed Slab | J  | Regular    |
       | Mono       | K  | Semibold   |
       | Mono Slab  | SC | Bold       |
       | Term       | TC |            |
       | Term Slab  |    |            |

That is really a whole lot, especially as the font files are huge.
A good candidate would be the .ttc, but unfortunately - although we can process them finally - I have found no way to keep them concise (keep sharing glyphs).

Maybe we can cut that number of fonts downs dramatically, and/or help @jonz94 to keep up with Nerd Font changes.

@Finii
Copy link
Collaborator

Finii commented Oct 28, 2022

Ah, they assemble the separate fonts into ttcs afterwards

Would be interesting to see if the tool they use is better with repacking than we are (which is fontforge, which's ttc support seems to be rudimentary).

Our ttc support has been added here:

@Finii
Copy link
Collaborator

Finii commented Jan 30, 2023

Closing because transferred to #1095

@Finii Finii closed this as completed Jan 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2023
@Finii Finii added the keep_unlocked Allow discuissions for extended time even after closing label Apr 18, 2024
@Finii Finii removed this from the v3.0.0 milestone Apr 18, 2024
Repository owner unlocked this conversation Apr 18, 2024
@cloud-yu
Copy link

cloud-yu commented Sep 5, 2024

Sarasa-Gothic-Nerd-Fonts patch failed because SNFT limits 65535 glyph, any help?

@Finii
Copy link
Collaborator

Finii commented Sep 5, 2024

@cloud-yu

https://github.com/jonz94/Sarasa-Gothic-Nerd-Fonts/actions/runs/10542676278/job/29209788923

The 'sfnt' format is currently limited to 65535 glyphs, and your font has 65910 of them.

That is a limitation of the fonts in general and can not be changed / extended.

Nerd Fonts adds up to ~10`000 glyphs, Sarasea already has many many, so the total is too many glyphs.
Possible solutions:

  • Do not patch in sets that are not needed (i.e. do not patch in the material design icons). That reduces the number of glyphs font-patcher adds and helps to keep the total number below 64k.
  • Use the Symbols Only font and fontfallback, then you do not need a patched font at all. But that
    • Is not possible in all situations
    • does not always place the icons in good position relative to the cell

And/or you can drop some of the original glyphs of Sarasea that are seldom/never used (if there are any).

There is in fact not any complete nice solution, sorry.

@Finii
Copy link
Collaborator

Finii commented Sep 5, 2024

Ah jonz94 already did drop some icons ... *sigh*

jonz94/Sarasa-Gothic-Nerd-Fonts#29 (comment)

As the number of glyphs of Nerd Fonts increases over time this will get worse :-(

@Finii
Copy link
Collaborator

Finii commented Sep 5, 2024

Hmm, happened out of the blue with same commit?!

image

Did you inform / seek help from jonz94?

@cloud-yu
Copy link

same commit, but sarasa version is different.
things get worse as you said, more glyphs should be dropped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❲Aa❳ new font keep_unlocked Allow discuissions for extended time even after closing
Projects
None yet
Development

No branches or pull requests

9 participants